Hey all,
Drew here
I am a smart contract developer for Phi Labs. I’d like to re-open the discussion about increasing callback_gas_limit
for the x/callback module.
I propose we increase the limit to 3_000_000
gas units, as was originally suggested by @xenosgeck.
Discussion So Far
This proposal was initially discussed in this forum post.
Public sentiment was positive, but didn’t generate a lot of discussion. callback_gas_limit
was eventually raised to 3 mill. on Constantine testnet but, as yet, there’s not been a proposal for this on Triomphe mainnet.
Why 3_000_000
Gas Units?
3 million gas units is a good limit for the following reasons:
- Original value of 1 million gas units was always intended as a temporary security measure until better consensus about a “good” limit
x/callback
was released in v7 and optimized in v9 (latest release)- It’s been out since 8 months, and 3 mill. gas still seems like the sweet spot
callback_gas_limit
on Constantine is already 3 million gas units and has been stable for 4-ish months- 3 mill. gas supports most smart contract txs
- It doesn’t support bigger txs like this one instantiating Archies NFT
- But it’s fine for a wide variety of txs, which aren’t currently possible, like:
Why is this Gas Increase Needed?
Beyond enabling trading callbacks for NFTs and Astrovault swaps, Phi Labs needs this proposal passed before we can launch a new product that relies on x/callback
for auto-compounding staking rewards. This new product will provide users on Archway Network with similar functionality to REStake, which doesn’t currently support Archway Network.
Proposal Parameters
Re-posting the original proposal parameters, from @xenosgeck, here for visibility:
draft_proposal.json
{
"messages": [
{
"@type": "/archway.callback.v1.MsgUpdateParams",
"authority": "archway10d07y265gmmuvt4z0w9aw880jnsr700j0f0puy",
"params": {
"callback_gas_limit": "3000000",
"max_block_reservation_limit": "10",
"max_future_reservation_limit": "432000",
"block_reservation_fee_multiplier": "0.000000000000000000",
"future_reservation_fee_multiplier": "1000000000000.000000000000000000"
}
}
],
"metadata": "ipfs://CID",
"deposit": "1000000000000000000aconst",
"title": "Update callback gas limit param",
"summary": "Increase callback gas limit param to 3000000"
}
draft_metadata.json
{
"title": "Update callback gas limit param",
"authors": [
"xenosgeck"
],
"summary": "Increase callback gas limit param",
"details": "Increase callback gas limit param to 3000000",
"proposal_forum_url": "https://gov.archway.io/t/proposal-increase-the-callback-gas-limit/606",
"vote_option_context": "Yes, No, NoWithVeto, Abstain"
}